search

tschellenbach / Django-facebook

Facebook open graph api implementation using the Django web framework in python
http://www.mellowmorning.com/
Other
1.43k stars 543 forks source link

Fix unit tests + add django 1 11 compatibility #594

Closed artoonie closed 7 years ago

artoonie commented 7 years ago

getLogger now produces a cryptic error saying a handler could not be found, which suppresses all error messages. I have opted to remove getLogger and just use the default logger always.

Apologize for combining a feature (django 1.11 support) to a bugfix (fixing the other failing tests). Let me know if you'd like them separated into two PRs.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 08d4ba08a72eaeb0149d8102c2320c4d0a7211bd on artoonie:bugfix/django-1-11-compatibility into on tschellenbach:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 08d4ba08a72eaeb0149d8102c2320c4d0a7211bd on artoonie:bugfix/django-1-11-compatibility into on tschellenbach:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 08d4ba08a72eaeb0149d8102c2320c4d0a7211bd on artoonie:bugfix/django-1-11-compatibility into on tschellenbach:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 08d4ba08a72eaeb0149d8102c2320c4d0a7211bd on artoonie:bugfix/django-1-11-compatibility into on tschellenbach:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 08d4ba08a72eaeb0149d8102c2320c4d0a7211bd on artoonie:bugfix/django-1-11-compatibility into on tschellenbach:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling a5d33f83a9cca2226da9c71a2b90432f0c075550 on artoonie:bugfix/django-1-11-compatibility into on tschellenbach:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 36b577994907c0ad25fa1b0d5138b1e82082234b on artoonie:bugfix/django-1-11-compatibility into on tschellenbach:master.

artoonie commented 7 years ago

@tschellenbach This pull request is ready for review :)

tschellenbach commented 7 years ago

Thank you! Looks good. Much appreciated. I don't have much time to look at this project lately.