Open DJFliX opened 5 years ago
Hi! I just made a short install test on osx 10.12 using both yarn 1.10.1 and npm 6.4.1 (node 10.8.0) and yes the build of the serialport dependency failed in both runs.
The current version of at-commander is dependent on serialport 5.0.0, which worked at the time. Trying to install/build serialport 5.0.0 only will fail the same way for me.
The current version of serialport 7.1.0 might indeed have some breaking changes so simply using that instead of the older version might not work.
If you're looking into that I won't say no :)
I tested with the latest v6 of serialport and that seemed to work. Unfortunately there does not seem to be some kind of test suite in this project or something so I'm not sure you should take my word for it... Probably the best thing to do is just try it I guess?
Heja! Many thanks for testing. Alas, testing would be the best thing or otherwise checking if the signature/behaviour of the used serialport functions have changed.
True, a test suite would indeed be good. Not sure when I find the time to take care of it..
Full yarn output:
Adding resolutions to the package.json file allows to install but does not seem to work properly (I'm looking in to that).