search

tschneidereit / SwiftSuspenders

NOTE: Find the offical repo at http://github.com/robotlegs/swiftsuspenders
https://github.com/robotlegs/swiftsuspenders
MIT License
280 stars 89 forks source link

Reflector #65

Closed darscan closed 12 years ago

darscan commented 12 years ago

Just some observations.

There is a Reflector, but getConstructor() sits outside and is a package level function. Why is that?

Also, getClass() accepts an ApplicationDomain but doesn't use it. Surely getConstructor should also accept an ApplicationDown and use it if passed?

tschneidereit commented 12 years ago

Good point about getConstructor. I've just removed that function and folded it into Reflector#getClass.

Also, I've removed the ApplicationDomain argument from getClass. As I removed support for using FQCNs as the first argument earlier, it's not needed anymore.

Thanks for the comments!