search

tschneidereit / SwiftSuspenders

NOTE: Find the offical repo at http://github.com/robotlegs/swiftsuspenders
https://github.com/robotlegs/swiftsuspenders
MIT License
280 stars 89 forks source link

Constructor injection fix #84

Closed chwthewke closed 11 years ago

chwthewke commented 11 years ago

I found an issue in constructor injection where some dependencies would surprisingly be injected as null when recursively applying ConstructorInjectionPoint injection.

This was caused by the use of a private static const _parameterValues: Array in MethodInjectionPoint.as.

A first commit has a new test to help ascertain that this is a reasonable use case. The test fails at that revision.

The second commit changes MethodInjectionPoint.as to make the test pass.

darscan commented 11 years ago

I have bumped into this myself.

tschneidereit commented 11 years ago

Urgh, what an embarrassing bug! Thanks a lot for fixing it. :)