search

tschoffelen / php-pkpass

💳 PHP class for creating passes for Wallet on iOS.
https://includable.com
MIT License
911 stars 188 forks source link

Add missing types #109

Closed fauVictor closed 3 years ago

fauVictor commented 3 years ago

I add missing types and fix some typo.

tschoffelen commented 3 years ago

Nice work, thanks! Since we're adding typed parameters and return types, which I think are only available from PHP 7.0 onwards, we probably need to bump the minimum PHP version in composer.json as well, and I should release this as a major version probably to indicate the backwards incompatibility.

fauVictor commented 3 years ago

No problem !

Let me know when you want to do the next release.If I have time, I want to help on this project.

tschoffelen commented 3 years ago

Oh no need to close this PR! Happy for it to stay open.

Just suggesting that we need to change composer.json to reflect the new PHP version requirement.

Once that's added this can be merged into master, and then I can tag a new version release.