search

tschoffelen / php-pkpass

💳 PHP class for creating passes for Wallet on iOS.
https://includable.com
MIT License
916 stars 187 forks source link

Add a remote certificate #82

Closed GCalmels closed 6 years ago

GCalmels commented 6 years ago

I have a certificate in S3 and I have an error in the PKPass constructor. I guess it is normal because file_exists does not work with remote files but is there a solution to add a remote certificate ?

tschoffelen commented 6 years ago

True, I guess file_exists doesn't work, so the library would require code changes, unless of course you would be okay with temporarily storing the certificate locally and then removing it after use, which I guess file_get_contents internally would also do when using a remote file URL.

I would be okay with accepting a PR to change the library so that it accepts remote URLs for the certificate.

tschoffelen commented 6 years ago

Fixed in #83.

lock[bot] commented 6 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.