tschoffelen / react-native-email-link

📭 Open an email client from React Native (for 'magic link' type functionality).
MIT License
412 stars 74 forks source link

Body text is not showing completely it's cutting out. #103

Open uasghar-smile opened 2 years ago

uasghar-smile commented 2 years ago

Hi I am having an issue while trying to send an email body text is not showing completely

uasghar-smile commented 2 years ago

Hi @tschoffelen can you please assist me on this why my body text is not being shown completely. Platform: "IOS"

jahirfiquitiva commented 8 months ago

@tschoffelen @danielmark0116

We are facing this very same issue.

This is a text we are using to test:

! " # $ % & ' ( ) * + , - . / 0 1 2 3 4 5 6 7 8 9 : ; < = > ? @ A B C D E F G H I J K L M N O P Q R S T U V W X Y Z [ \ ] ^ _ ` a b c d e f g h i j k l m n o p q r s t u v w x y z { | } ~

These are the results of our tests:

Without encodeBody, or encodeBody: false

Apple Email Gmail Outlook
IMG_2504 IMG_2505 IMG_2506

With encodeBody: true

Apple Email Gmail Outlook
IMG_2507 IMG_2508 IMG_2509

In this one, I think spaces ( ) should not be encoded.

tschoffelen commented 6 months ago

Thanks for testing that @jahirfiquitiva!

Ideally, I think we should customise if/how we encode the body based on the email client chosen, and deprecate the encodeBody parameter. I don't have time in the foreseeable future to work on this myself, but would be more than happy to accept a PR of course!

github-actions[bot] commented 4 months ago

This issue is stale because it has been open for 60 days with no activity.

jahirfiquitiva commented 4 months ago

This should not be marked as stale, the issue is still present

tschoffelen commented 3 months ago

Heya @jahirfiquitiva! Happy to accept a PR to fix this, I am not currently using the email composer option of the lib myself, and don't have time to look into it at the moment

jahirfiquitiva commented 3 months ago

@tschoffelen I don't feel confident in my react-native knowledge as to be able to provide a PR to fix this. But hopefully in the near future.

pke commented 1 month ago

Spaces could be encoded as "+", I'll check if the clients support that.

tschoffelen commented 1 month ago

Yeah it seems to differ between clients - appreciate it!