search

tschoffelen / react-native-email-link

📭 Open an email client from React Native (for 'magic link' type functionality).
MIT License
412 stars 74 forks source link

feat(android): add namespace to support AGP 8 #127

Closed AndreiCalazans closed 1 year ago

AndreiCalazans commented 1 year ago

Trivial change to support AGP 8 as mentioned here: https://github.com/react-native-community/discussions-and-proposals/issues/671

This does not remove package attribute from AndroidManifest to not lose compatibility with AGP < 8 (React Native < 0.71 versions).

I don't think it's worth maintaining logic to remove that attribute contitionally since it will only cause a warning to users on AGP 8 and above.

tschoffelen commented 1 year ago

Great, thanks for updating this!

tschoffelen commented 1 year ago

Released to NPM as react-native-email-link@1.14.7