search

tschoffelen / react-native-email-link

📭 Open an email client from React Native (for 'magic link' type functionality).
MIT License
409 stars 74 forks source link

Optional title and message #23

Closed Taylor123 closed 5 years ago

tschoffelen commented 5 years ago

Making them optional is fine, but this also removes the default values as far as I can tell.

Wouldn't passing null to the title and message params achieve your intended result?

Taylor123 commented 5 years ago

@tschoffelen on iOS you'll get the error: NSNull cannot be converted to NSString and on the android implementation any falsy value will be replaced with the default string

Taylor123 commented 5 years ago

i could add another argument to the function and adjust if you'd prefer it

tschoffelen commented 5 years ago

That might be a better solution indeed!

tschoffelen commented 5 years ago

Great! This also fixes #7. Thanks!

tschoffelen commented 5 years ago

Published to NPM as react-native-email-link@1.3.0.