search

tschoffelen / react-native-email-link

📭 Open an email client from React Native (for 'magic link' type functionality).
MIT License
409 stars 74 forks source link

Remove override of createJSModules #39

Closed AfrazHussain closed 5 years ago

AfrazHussain commented 5 years ago

This PR removes the Override in on the createJSModules call. For more information: https://github.com/facebook/react-native/commit/ce6fb337a146e6f261f2afb564aa19363774a7a8

I have tested and everything works fine on RNv0.61.2.

tschoffelen commented 5 years ago

Looks good. Am I correct however in assuming this will beak compatibility for any users using RN < 0.61.2?

AfrazHussain commented 5 years ago

I don't think this will break compatibility. Nothing that I could find regarding that. This was introduced in RN 0.47 as a breaking change (as you can see in this link https://github.com/facebook/react-native/commit/ce6fb337a146e6f261f2afb564aa19363774a7a8), so I highly doubt this will break anything for anyone. There is legacy code for other people nonetheless.

tschoffelen commented 5 years ago

Oh sorry, didn't notice it was that old! All good then!

tschoffelen commented 5 years ago

Published to NPM as react-native-email-link@1.6.2.