search

tschoffelen / react-native-email-link

📭 Open an email client from React Native (for 'magic link' type functionality).
MIT License
409 stars 74 forks source link

README.md doesn't describe options #7

Closed mvanroon closed 5 years ago

mvanroon commented 6 years ago

Great util guys. I just noticed that the options that can be supplied to openInbox() aren't in the readme

mvanroon commented 6 years ago

@tschoffelen Just found this old issue, heh :)

I can pick this up myself if you like. Should we make the options optional? Neither ActionSheetIOS nor the Android native module require a title.

tschoffelen commented 6 years ago

For usability, I would just keep the default ones if no/empty values are specified. Although a title isn't required, a ActionSheet with only the names of the email clients might not be the clearest thing in the world.

mvanroon commented 6 years ago

might be a bit too much if you ask me - but I'll settle for just making the options.message optional. Is that something that you can live with? 😸

tschoffelen commented 6 years ago

Haha, agreed. I think we can even remove the default value for message. Title is indeed more than enough.