tschoffelen / react-native-map-link

🗺 Open the map app of the user's choice.
MIT License
670 stars 140 forks source link

not working on expo 51 #300

Closed fozzarelo closed 2 weeks ago

fozzarelo commented 3 months ago

I migrated from expo 50 to 51 and the feature stopped working. No errors or warnings displayed.

have you tested it with sdk51?

thank you for the great library.

dani-z commented 3 months ago

@fozzarelo I am running latest expo 51.0.24 and works perfectly fine for me.

tschoffelen commented 2 months ago

Hi @fozzarelo! Sorry to hear you're having problems getting the library to work.

Some pointers that might help:

markaustinws commented 2 months ago

I'm also experiencing issues with this. getApps for me is only returning Google maps. I have Waze installed too. However, to launch, I have to specify that I want to use Waze. By default it always launches Google Maps. Runnin Expo GO on my tablet. Would I need a build to pick up the rest?

I have read that the way in which default apps on Android 12+ has changed.

I don't really want to implement a Map App chooser and just use the one that's been configured by default on the device

tschoffelen commented 2 months ago

Hi @markaustinws - this is the expected behaviour on Expo Go - the Expo Go app isn't whitelisted to query existence of other apps on the system. Only native builds with the Expo plugin installed will allow you to do this.

markaustinws commented 2 months ago

Hi @tschoffelen Thanks for confirming. Great library! :)

markaustinws commented 2 months ago

I've created a preview iOS build. Uploaded to Browser Stack, but when attempting to launch, I'm getting the following errors: Aug 23 16:10:58 WSCrewDev(UIKitCore)[4616] : Info.plist contained no UIScene configuration dictionary (looking for configuration named "(no name)")Aug 23 16:11:55 WSCrewDev(Network)[4616] : nw_read_request_report [C1] Receive failed with error "Software caused connection abort"Aug 23 16:13:27 WSCrewDev(CoreLocation)[4616] : This method can cause UI unresponsiveness if invoked on the main thread. Instead, consider waiting for the -locationManagerDidChangeAuthorization: callback and checking authorizationStatus first.Aug 23 16:13:27 WSCrewDev(libCoreFSCache.dylib)[4616] : fopen failed for data file: errno = 2 (No such file or directory)Aug 23 16:13:27 WSCrewDev(libCoreFSCache.dylib)[4616] : Errors found! Invalidating cache...Aug 23 16:14:12 WSCrewDev(libsystem_containermanager.dylib)[4616] : container_create_or_lookup_app_group_path_by_app_group_identifier: client is not entitledAug 23 16:14:12 WSCrewDev(libsystem_containermanager.dylib)[4616] : container_create_or_lookup_app_group_path_by_app_group_identifier: client is not entitledAug 23 16:14:12 WSCrewDev(libsystem_containermanager.dylib)[4616] : container_create_or_lookup_app_group_path_by_app_group_identifier: client is not entitledAug 23 16:14:12 WSCrewDev(libsystem_containermanager.dylib)[4616] : container_create_or_lookup_app_group_path_by_app_group_identifier: client is not entitledAug 23 16:14:12 WSCrewDev(libsystem_containermanager.dylib)[4616] : container_create_or_lookup_app_group_path_by_app_group_identifier: client is not entitledAug 23 16:14:13 WSCrewDev(libsystem_containermanager.dylib)[4616] : container_create_or_lookup_app_group_path_by_app_group_identifier: client is not entitledAug 23 16:15:50 WSCrewDev(CFNetwork)[4616] : Received XPC error Connection interrupted for message type 3 kCFNetworkAgentXPCMessageTypePACQueryAug 23 16:15:50 WSCrewDev(CFNetwork)[4616] : Received XPC error Connection invalid for message type 3 kCFNetworkAgentXPCMessageTypePACQueryAug 23 16:19:29 WSCrewDev(CFNetwork)[4616] : Received XPC error Connection interrupted for message type 3 kCFNetworkAgentXPCMessageTypePACQueryAug 23 16:19:29 WSCrewDev(CFNetwork)[4616] : Received XPC error Connection invalid for message type 3 kCFNetworkAgentXPCMessageTypePACQuery

tschoffelen commented 2 months ago

None of these messages seem to be related to this library as far as I can tell @markaustinws

mrevanzak commented 2 months ago

its working on me. make sure to run expo prebuild --clean and rebuild the development apps

markaustinws commented 2 months ago

Hi @mrevanzak - Thanks. Last day before leave and I didn't realise that BrowserStack doesn't preload with any map applications. Installed Google Maps on the BrowserStack IOS instance and is now working.

tschoffelen commented 2 weeks ago

Looks like this can be closed for now - feel free to re-open if it's still a problem!