search

tschoonj / xraylib

A library for X-ray matter interaction cross sections for X-ray fluorescence applications
https://github.com/tschoonj/xraylib/wiki
Other
120 stars 55 forks source link

BLD : python3 compatibility #14

Closed tacaswell closed 9 years ago

tacaswell commented 9 years ago

Use from future import print_function when extracting the path to the numpy includes

There is a bunch of white space changes (my editor strips trailing white space on save), but the important change is around L541.

tschoonj commented 9 years ago

Many thanks for the patch!

I will release version 3.1.0 in two weeks, which will include this change…

Happy to see Brookhaven is also using xraylib :-)

tacaswell commented 9 years ago

Some what related, I have a draft of a conda recipe (on the xraylib branch of conda-recipes on my gh account) for xraylib. The conda folks are starting a push to get oss projects to self-host recipes, would you like a PR with that against this repo?

tschoonj commented 9 years ago

Never heard about conda before. Would I have to distribute this recipe along with the source tarball? Or is it sufficient to keep it in the github repo?

tacaswell commented 9 years ago

Probably just in the repo, the conda will go out and get the tarball for you.

It is very light weight, just two text files. One is a build script (which is useful on linux independent of conda) and a yaml file of dependencies.

tacaswell commented 9 years ago

For reference https://store.continuum.io/cshop/anaconda/

tschoonj commented 9 years ago

Well if all I need to do is pull in two files, then I don't mind providing conda support.

Best,

Tom

Op 26-aug.-2014, om 22:56 heeft Thomas A Caswell notifications@github.com het volgende geschreven:

Probably just in the repo, the conda will go out and get the tarball for you.

It is very light weight, just two text files. One is a build script (which is useful on linux independent of conda) and a yaml file of dependencies.

— Reply to this email directly or view it on GitHub.

tacaswell commented 9 years ago

Great. It is actually 3 files (windows needs it's own build script). I will put in a PR once they seem to be working.