tschoonj / xraylib

A library for X-ray matter interaction cross sections for X-ray fluorescence applications
https://github.com/tschoonj/xraylib/wiki
Other
120 stars 54 forks source link

Fix python memory leak #193

Closed tschoonj closed 2 years ago

tschoonj commented 2 years ago

Closes #192

tschoonj commented 2 years ago

@djvine the fix in this PR seems to fix the memory leak for me. Can you confirm this?

djvine commented 2 years ago

PR fixes the memory leak.

Thanks!

tschoonj commented 2 years ago

Many thanks for confirming that this PR fixes the issue. I will try and make a new release as soon as possible.

By the way, if your company continues to use xraylib, it would be great if you could consider sponsoring me to keep me incentivised to keep working on it.

uvainio commented 2 years ago

Tom, unfortunately it's difficult for companies to sponsor anything due to various regulations and complications. It's easier for example to buy consulting for a specific task. Unfortunately.

tschoonj commented 2 years ago

Tom, unfortunately it's difficult for companies to sponsor anything due to various regulations and complications. It's easier for example to buy consulting for a specific task. Unfortunately.

This may be true for Hitachi, but is certainly not true in general. I am not sure why this would need be done through consulting: I would argue that sponsoring an open-source project is similar to paying for licenses of commercial software packages.

After my departure from the X-ray spectroscopy community, xraylib has now become a Sunday afternoon hobby project with a bus-factor of 1. While I am happy that xraylib is extensively used throughout industry, I would consider it to be rather risky for anyone there to continue using it for anything that can be considered as business critical, as you are basically pinning your hopes on myself continuing to develop and maintain it, unpaid, while sacrificing precious spare time that I could/should be spending with my wife and son.

For example, finding and fixing the bug that was reported by @djvine, followed by making the new release took about 5 hours out of my weekend, and I do very much like my weekends 😏

djvine commented 2 years ago

Tom,

I understand where you are coming from and I’ll raise it with my cfo to see what we can do.

Thanks David

On Sun, Feb 13, 2022 at 9:38 AM Tom Schoonjans @.***> wrote:

Tom, unfortunately it's difficult for companies to sponsor anything due to various regulations and complications. It's easier for example to buy consulting for a specific task. Unfortunately.

This may be true for Hitachi, but is certainly not true in general. I am not sure why this would need be done through consulting: I would argue that sponsoring an open-source project is similar to paying for licenses of commercial software packages.

After my departure from the X-ray spectroscopy community, xraylib has now become a Sunday afternoon hobby project with a bus-factor of 1. While I am happy that xraylib is extensively used throughout industry, I would consider it to be rather risky for anyone there to continue using it for anything that can be considered as business critical, as you are basically pinning your hopes on myself continuing to develop and maintain it, unpaid, while sacrificing precious spare time that I could/should be spending with my wife and son.

For example, finding and fixing the bug that was reported by @djvine https://github.com/djvine, followed by making the new release took about 5 hours out of my weekend, and I do very much like my weekends 😏

— Reply to this email directly, view it on GitHub https://github.com/tschoonj/xraylib/pull/193#issuecomment-1038288272, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLDBWCJF3OSLTJ2F53GFWDU27UCXANCNFSM5OGIQW7A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- David