search

tschoonj / xraylib

A library for X-ray matter interaction cross sections for X-ray fluorescence applications
https://github.com/tschoonj/xraylib/wiki
Other
123 stars 56 forks source link

Pascal #21

Closed wormy69 closed 9 years ago

wormy69 commented 9 years ago

Simplified Pascal bindings and tested with Delphi and Lazarus under Windows 7 and OSX Yosemite

tschoonj commented 9 years ago

Hi Matthew,

Looks good. Can you explain me why the last commit is necessary (the underscores on Mac OS X)? Does this work with both FPC and Delphi?

wormy69 commented 9 years ago

The additional underscore is only needed by the Delphi compiler

http://docwiki.embarcadero.com/RADStudio/XE7/en/Shared_Libraries_for_Mac_OS_X

The underscore is handled automatically by the FPC compiler / linker and so is not needed

To this end I use the MACOS symbol that is defined for Delphi under OSX but not for FPC (which uses DARWIN).

The binding has been tested and works with both Delphi and FPC. I just happened to work through checking in the binding to Git before trying to build the universal library and then finding the need for the underscore in Delphi on OSX.

Matthew

From: Tom Schoonjans [mailto:notifications@github.com] Sent: Thursday, April 02, 2015 1:18 AM To: tschoonj/xraylib Cc: Matthew Wormington Subject: Re: [xraylib] Pascal (#21)

Hi Matthew,

Looks good. Can you explain me why the last commit is necessary (the underscores on Mac OS X)? Does this work with both FPC and Delphi?

— Reply to this email directly or view it on GitHubhttps://github.com/tschoonj/xraylib/pull/21#issuecomment-88785027.

tschoonj commented 9 years ago

Thanks for the work, I pulled it in.

One thing though: you should set up your name and email as said in https://help.github.com/articles/set-up-git/#setting-up-git Unfortunately, now you show up as 'unknown' for these commits :-(

wormy69 commented 9 years ago

Will do and not to worry, I added my name along with yours at the top of the xraylib.pas file.

I setup GitHub but not the Git software I guess.

Matthew

From: Tom Schoonjans [mailto:notifications@github.com] Sent: Thursday, April 02, 2015 10:53 AM To: tschoonj/xraylib Cc: Matthew Wormington Subject: Re: [xraylib] Pascal (#21)

Thanks for the work, I pulled it in.

One thing though: you should set up your name and email as said in https://help.github.com/articles/set-up-git/#setting-up-git Unfortunately, now you show up as 'unknown' for these commits :-(

— Reply to this email directly or view it on GitHubhttps://github.com/tschoonj/xraylib/pull/21#issuecomment-88973367.

wormy69 commented 9 years ago

And thanks for you for maintaining this project – it’s a valuable resource for the X-ray community and so I am only too happy to make some contributions.

Matthew

From: Tom Schoonjans [mailto:notifications@github.com] Sent: Thursday, April 02, 2015 10:53 AM To: tschoonj/xraylib Cc: Matthew Wormington Subject: Re: [xraylib] Pascal (#21)

Thanks for the work, I pulled it in.

One thing though: you should set up your name and email as said in https://help.github.com/articles/set-up-git/#setting-up-git Unfortunately, now you show up as 'unknown' for these commits :-(

— Reply to this email directly or view it on GitHubhttps://github.com/tschoonj/xraylib/pull/21#issuecomment-88973367.

tschoonj commented 9 years ago

You’re most welcome.

Will continue to maintain it as long as I can.

In a couple of weeks or months I will get back in touch when the time comes to start packaging for the next release. I should have a look at the partial PE cross sections first, as they create some kind of internal inconsistency with regard to the total PE cross sections.

Best,

Tom

Dr. Tom Schoonjans Research Fellow

Bundesanstalt für Materialforschung und -prüfung (Federal Institute for Materials Research and Testing) Richard-Willstätter-Strasse 11, 12489 Berlin Germany

Telephone +49 (0) 30-8104-5612

Tom.Schoonjans@bam.demailto:Tom.Schoonjans@bam.de www.bam.de

On 02 Apr 2015, at 19:00, Matthew Wormington notifications@github.com<mailto:notifications@github.com> wrote:

And thanks for you for maintaining this project – it’s a valuable resource for the X-ray community and so I am only too happy to make some contributions.

Matthew

From: Tom Schoonjans [mailto:notifications@github.com] Sent: Thursday, April 02, 2015 10:53 AM To: tschoonj/xraylib Cc: Matthew Wormington Subject: Re: [xraylib] Pascal (#21)

Thanks for the work, I pulled it in.

One thing though: you should set up your name and email as said in https://help.github.com/articles/set-up-git/#setting-up-git Unfortunately, now you show up as 'unknown' for these commits :-(

— Reply to this email directly or view it on GitHubhttps://github.com/tschoonj/xraylib/pull/21#issuecomment-88973367.

— Reply to this email directly or view it on GitHubhttps://github.com/tschoonj/xraylib/pull/21#issuecomment-88974934.