search

tschoonj / xraylib

A library for X-ray matter interaction cross sections for X-ray fluorescence applications
https://github.com/tschoonj/xraylib/wiki
Other
120 stars 55 forks source link

Windows installer kills path #31

Closed adler-j closed 8 years ago

adler-j commented 8 years ago

It seems the current windows installer actually removes the PATH and sets it to PATH=C:\Program Files (x86)\xraylib\Bin. This is, for obvious reasons, not very good.

tschoonj commented 8 years ago

This is very surprising: that installer has been out for 18 months now and you are the first one bringing this up. I have tested this myself many times and have never encountered this. There is also no code in the installer script that could do this.

Could you give me some more information?

I assume you are referring to the 3.1.0 installer? 32-bit or 64-bit? What version of Windows are you running?

Before installing, was there already an older version of xraylib installed?

Was your path variable already very long before you installed xraylib?

Thanks,

Tom

adler-j commented 8 years ago

This is very surprising: that installer has been out for 18 months now and you are the first one bringing this up. I have tested this myself many times and have never encountered this. There is also no code in the installer script that could do this.

Could you give me some more information?

Sure will do

I assume you are referring to the 3.1.0 installer? 32-bit or 64-bit? What version of Windows are you running?

This is where I admit that I clicked the 2.16 installer by misstake, regardless it holds for both the 2.16 and the 2.16-cli installers (I tried). They are both 32-bit. I am running 64-bit. No errors during installation.

Before installing, was there already an older version of xraylib installed?

No.

Was your path variable already very long before you installed xraylib?

Quite long, yes, but not too long (I can append xraylib once i have installed without hitting the "roof".)

I'll try the 3.1 installer now.

Edit: 3.1 installer works perfectly.

My suggestion: remove the old installers from the download page, or at least put them in a "deprecated" subfolder.

tschoonj commented 8 years ago

Ok, I understand the problem now. The old installers used NSIS instead of InnoSetup, and these NSIS installers were (are) notorious for chopping off very long environment variable values (1 kB by default) when appending to them.

Fortunately the InnoSetup installers do not display this problem...

Sorry about this! Hope you could recover its contents!

adler-j commented 8 years ago

Ok great, it does indeed seem like the new one works fine!

If anyone else finds this issue and has this problem, this solves it:

http://stackoverflow.com/questions/7956365/need-to-recover-older-path-setting