tschoppi / starsystem-gen

Automated Generation of a GURPS 4e Star System as described in GURPS: Space
Other
40 stars 16 forks source link

Incorrect display of orbits #71

Open JoshuaClick opened 2 years ago

JoshuaClick commented 2 years ago

The current web version displays orbits as ellipses centered on the star.

This is incorrect. Actual orbits are ellipses with one of the foci on the barycenter, or the common center of mass of the system. In practice, for a star system, the barycenter will be inside the parent star and so one of the foci should be centered on the star.

JoshuaClick commented 2 years ago

I have a fix, incidentally, but no idea how to present it.

tschoppi commented 2 years ago

Thanks for this input! If you already have a fix, could you provide it as a pull request?