tschwecke / harvey

Easy and fast integration testing of RESTful web services
21 stars 9 forks source link

bump request to fix sslv3 issue. update nock pattern matching for oauth #90

Closed ginman86 closed 9 years ago

ginman86 commented 9 years ago

Update to latest request module to pull in fixes for SSLv3 vulns. Old request module on newer node (<=4.0.0) would bomb with this error when doing https:

> harvey -c test/integration/config.json test/integration/c2c.tests.json

(node) sys is deprecated. Use util instead.
_tls_common.js:23
      this.context.init(secureProtocol);
                   ^

Error: SSLv3 methods disabled
    at Error (native)
    at new SecureContext (_tls_common.js:23:20)
    at Object.createSecureContext (_tls_common.js:42:11)
    at Object.exports.connect (_tls_wrap.js:955:21)
    at Agent.createConnection (https.js:73:22)
    at Agent.createSocket (_http_agent.js:177:16)
    at Agent.addRequest (_http_agent.js:146:23)
    at new ClientRequest (_http_client.js:133:16)
    at Object.exports.request (http.js:31:10)
    at Object.exports.request (https.js:163:15)
ginman86 commented 9 years ago

@mac- ^^

tschwecke commented 9 years ago

Thanks Greg, this has been merged in and published as v0.5.5

mac- commented 9 years ago

Thanks @tschwecke & @ginman86