Add test to replicate duplicate port hints issue

tscircuit / builder

11 stars 7 forks source link

Closed abhijitxy closed 3 months ago

abhijitxy commented 3 months ago

[x] Added a test to replicate the issue of duplicate port hints by creating a bug with footprint="soic8".

abhijitxy commented 3 months ago

@seveibar review it

abhijitxy commented 3 months ago

Yeah @seveibar, I know. I'll fix the bug. Thanks for the catch!

seveibar commented 3 months ago

Looks good, good fix. Normally i approve with suggestions but since this is an early pr i requested changes

seveibar commented 3 months ago

@abhijitxy i think you're failing format, formatbot usually fixes this but cant on forks iirc, try running nom run format