If a port is intentionally not connected, `@tscircuit/checks` still throws an error saying the port is not connected - Githubissues

tscircuit / checks

Validity checks for tscircuit soup JSON

2 stars 2 forks source link

If a port is intentionally not connected, `@tscircuit/checks` still throws an error saying the port is not connected #7

Closed seveibar closed 4 months ago

seveibar commented 4 months ago

[ ] Create test case in tscircuit/checks where there are pcb ports that are not connected
[ ] Make sure that no errors are thrown unless there is supposed to be a trace connecting the pcb port

Some tips:

An unconnected pcb port is just a pcb_port associated with a source_port where source_port.connected_source_port_ids is missing or an empty array
A pcb port is also considered connected if any pcb_trace.route contains the pcb_port_id in start_pcb_port_id or end_pcb_port_id
the problematic function is checkEachPcbPortConnected