tscircuit / circuit-to-svg

Convert tscircuit Schematic/PCB JSON ("soup") into an SVG
https://circuit-to-svg.vercel.app
4 stars 5 forks source link

`pcb_hole` element doesn't render #47

Open seveibar opened 1 month ago

seveibar commented 1 month ago

Example file:

[
  {
    "type": "pcb_board",
    "pcb_board_id": "pcb_board_0",
    "center": {
      "x": 0,
      "y": 0
    },
    "width": 10,
    "height": 10
  },
  {
    "type": "pcb_hole",
    "pcb_hole_id": "pcb_hole_0",
    "hole_shape": "round",
    "hole_diameter": 2.031999934976002,
    "x": 3,
    "y": 1
  }
]

It should render like this:

image

homie-gg[bot] commented 1 month ago

This might have already been done via: implement Hole and pcb_hole rendering.

homie-gg[bot] commented 1 month ago

This might have already been done via: allow holes to be constrained, add typechecking on CI, implement ydist constraint solving, fix edgeToEdge constraint offset issue.

homie-gg[bot] commented 1 month ago

Here are some pull requests that might be helpful reference for this task:

homie-gg[bot] commented 1 month ago

This might have already been done via: add support for rendering holes onto board.

homie-gg[bot] commented 1 month ago

This might have already been done via: Detect round holes as obstacles fix.

tscircuitbot commented 1 month ago

Aider has created a pull request to address this issue: undefined

Please review the changes and provide feedback.

seveibar commented 1 month ago

@abhijitxy this one is a good option

homie-gg[bot] commented 1 month ago

This might have already been done via: updated circuit-to-svg and dependency.

seveibar commented 1 month ago

@abhijitxy is this one done?

seveibar commented 1 month ago

@abhijitxy

homie-gg[bot] commented 1 month ago

This might have already been done via: fix: rename pcb_hole.hole_shape "round" to "circle". Add a zod transform to correctly handle old data.

homie-gg[bot] commented 1 month ago

This might have already been done via: Fix hole shape enum issue.

homie-gg[bot] commented 1 month ago

This might have already been done via: support for plated holes and holes.

homie-gg[bot] commented 1 month ago

This might have already been done via: PCB Element Refactor, docs file for PCB Elements for better AI-assist.

homie-gg[bot] commented 1 month ago

This might have already been done via: Add support for rendering pcb_hole.

homie-gg[bot] commented 1 month ago

This might have already been done via: support correct pin positions for schematic box.

homie-gg[bot] commented 1 month ago

This might have already been done via: Update 3d viewer, core and pcb viewer. Add switches to keyboard example.

homie-gg[bot] commented 1 month ago

This might have already been done via: implemented pcb_hole in excellon drill and soldermask.