tscircuit / core

8 stars 17 forks source link

Refactor the trace so it does not get passed to the chip manufacturer part number and name #322

Closed anas-sarkez closed 1 week ago

anas-sarkez commented 1 week ago

this issue fixed with converting manufacturer labels as a schematic_text /claim #307 fixed #307 this example before fixed the issue

Screenshot 2024-11-17 at 9 16 07 PM

this is after fixed

Screenshot 2024-11-17 at 9 48 13 PM
anas-sarkez commented 1 week ago

All of schematic snapshots are changed _(color is black now)

Screenshot 2024-11-17 at 10 09 03 PM
anas-sarkez commented 1 week ago
Screenshot 2024-11-17 at 10 14 12 PM
anas-sarkez commented 1 week ago

@seveibar

now they are same color

Screenshot 2024-11-17 at 10 19 17 PM
seveibar commented 1 week ago

@anas-sarkez this looks good but you need to update all the snapshots before i can approve it

anas-sarkez commented 1 week ago

I will generate new snapshot test for all

anas-sarkez commented 1 week ago

@seveibar should I marge?

seveibar commented 1 week ago

@anas-sarkez no i need to review the snapshots, let me check

anas-sarkez commented 1 week ago

ok this is good, but please update circuit-to-svg to stop drawing the manufacturer part numbers because the double-layer looks bad

great work!

Ok

anas-sarkez commented 1 week ago

ok this is good, but please update circuit-to-svg to stop drawing the manufacturer part numbers because the double-layer looks bad

great work!

https://github.com/tscircuit/circuit-to-svg/pull/133