search

tscircuit / schematic-viewer

https://schematic-viewer.vercel.app
8 stars 6 forks source link

Feat/manufacturer part number #47

Closed imrishabh18 closed 4 months ago

imrishabh18 commented 4 months ago

Closes - https://github.com/tscircuit/tscircuit/issues/262

Screenshot 2024-07-21 at 12 02 07 AM
vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
schematic-viewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 5:18am
imrishabh18 commented 4 months ago

@seveibar Seems like even the schematic viewer will need some refactoring cause the typecheck failed, the types which are getting used are not in sync with the latest packages. 😅

seveibar commented 4 months ago

Side note: the visual regression worked!

image

imrishabh18 commented 4 months ago

This will be super helpful 🚀

imrishabh18 commented 4 months ago

@seveibar The typecheck is not failing in my local but it is here, I think it's because the latest soup build is not getting fetched here. I think this can be merged cause after the latest soup this will pass as well.

Screenshot 2024-07-22 at 9 57 12 AM
seveibar commented 4 months ago

@imrishabh18 just checking did you try npm i to get the latest versions of the deps?

seveibar commented 4 months ago

to upgrade the soup remotely you could do npm add @tscircuit/soup@latest

seveibar commented 4 months ago

FWIW i get a type error locally:

image

imrishabh18 commented 4 months ago

The manufacturerPartNumber has been added in the soup and merged now, I will take a look at this. I have yalc my soup so it's passing for me

imrishabh18 commented 4 months ago

All green 🟢

imrishabh18 commented 4 months ago

Taken care of the UI regression. Apologies, for these many to and fro