search

tscircuit / schematic-viewer

https://schematic-viewer.vercel.app
8 stars 6 forks source link

`<board />` center alignment bug #48

Closed imrishabh18 closed 3 months ago

imrishabh18 commented 4 months ago

File - https://github.com/tscircuit/schematic-viewer/blob/714e6a0189cd7ba887ffb20a4add964ba086417e/src/stories/bugs/bug8-autolayout.stories.tsx

<board /> props pcbCenterX and pcbCenterY which are depreciated when replaced with pcbX and pcbY is having bug

Current
Screenshot 2024-07-21 at 12 51 52 AM
After val update
Screenshot 2024-07-21 at 12 55 51 AM
seveibar commented 4 months ago

Anything in the console?

imrishabh18 commented 4 months ago

The props in react-fiber needs to be updated for this? @seveibar

Screenshot 2024-07-21 at 6 33 25 PM
seveibar commented 4 months ago

I just patched this in the latest version of builder yesterday https://github.com/tscircuit/builder/pull/79

cc @Slaviiiii