search

tscircuit / schematic-viewer

https://schematic-viewer.vercel.app
8 stars 6 forks source link

REF: replacing core.ts types with circuit-json exported types #64

Closed DhairyaMajmudar closed 1 month ago

DhairyaMajmudar commented 1 month ago

-> Replaced the types in core.ts files with those exported from the circuit-json package. -> closes #63

cc: @seveibar

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
schematic-viewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 8:43pm
seveibar commented 1 month ago

@DhairyaMajmudar I'm running the workflows for you, future contributions will automatically run but you have to get something merged first (some github rule).

Thanks for the PR!

imrishabh18 commented 1 month ago

Looks good! @DhairyaMajmudar. Can you please fix this type check which is failing?

DhairyaMajmudar commented 1 month ago

Looks good! @DhairyaMajmudar. Can you please fix this type check which is failing?

Thank you! I've fixed failing checks, can you pls. rerun the test : )

seveibar commented 1 month ago

nice contrib @DhairyaMajmudar

DhairyaMajmudar commented 1 month ago

nice contrib @DhairyaMajmudar

Thank you 😄