search

tscircuit / snippets

https://snippets.tscircuit.com
MIT License
3 stars 15 forks source link

Making cross button work #10

Closed DhairyaMajmudar closed 2 weeks ago

DhairyaMajmudar commented 3 weeks ago

-> The cross button will now hide the Onboarding Tips section after clicking

-> Screenshot

image

cc: @seveibar

DhairyaMajmudar commented 3 weeks ago

looks good but let's address the formatting before merging

Thanks! When I ran the command bun run format there were about 50 files which got formatted, let me open a PR for the same

seveibar commented 3 weeks ago

@DhairyaMajmudar woops so what happened here is the repo was formatted but your base branch was a bit behind. You could do this to fix the merge conflicts:

git fetch
git merge origin/main
# fix conflicts
git commit

you could also try to resolve conflicts inside github with "Resolve Conflicts", pull locally, then format

vercel[bot] commented 2 weeks ago

@DhairyaMajmudar is attempting to deploy a commit to the tscircuit Team on Vercel.

A member of the Team first needs to authorize it.

seveibar commented 2 weeks ago

@DhairyaMajmudar some format and typecheck issues 😭 sorry this one is taking a bit to merge because i think a lot was going on with the repo- wish i had merged on my original approval

DhairyaMajmudar commented 2 weeks ago

@DhairyaMajmudar some format and typecheck issues 😭 sorry this one is taking a bit to merge because i think a lot was going on with the repo- wish i had merged on my original approval

Oh! 😢 I've fixed the format issues can you pls. review again

seveibar commented 2 weeks ago

The first PR to a repo is always the most annoying because of the Github workflow protection... after this is merged it should be easier!!!