tscircuit / snippets

https://snippets.tscircuit.com
MIT License
3 stars 15 forks source link

Multiple lock files in codebase #3

Closed DhairyaMajmudar closed 3 weeks ago

DhairyaMajmudar commented 3 weeks ago

-> There are two lockfiles in the project codebase which are package-lock.json generated due to npm and bun.lockb generated due to bun

-> Having these two different lock files in the codebase causes PacakgeManager related issues so deleting one of them would be good to go

-> ScreenShot from VSCode

image

DhairyaMajmudar commented 3 weeks ago

POV: Removing package-lock.json would be a good decision to be taken reason being bun is faster in installing dependencies as compared to npm

What's your POV on this @seveibar ?

homie-gg[bot] commented 3 weeks ago

Here are some pull requests that might be helpful reference for this task:

imrishabh18 commented 3 weeks ago

@DhairyaMajmudar Good point! Yes, we can remove the package-lock file. I see @Complexlity has raised a PR for it as well.

Thanks for pointing this out