tscircuit / snippets

The main website, playground and online development environment for tscircuit (React Electronics)
https://tscircuit.com
MIT License
11 stars 28 forks source link

"Unsaved Changes" is always visible, even after saving #326

Open seveibar opened 1 day ago

seveibar commented 1 day ago

Image

/bounty $10

algora-pbc[bot] commented 1 day ago

💎 $25 bounty • tscircuit

Steps to solve:

  1. Start working: Comment /attempt #326 with your implementation plan
  2. Submit work: Create a pull request including /claim #326 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tscircuit/snippets!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🟢 @krushnarout Dec 2, 2024, 2:46:31 AM #328
🟢 @RohittCodes Dec 2, 2024, 10:12:10 AM WIP
RohittCodes commented 1 day ago

@seveibar @imrishabh18 not sure but maybe an issue in production. works fine locally https://github.com/user-attachments/assets/fe38d4ef-5001-444c-84be-11304aea4baa

krushnarout commented 1 day ago

/attempt #326

Algora profile Completed bounties Tech Active attempts Options
@krushnarout 1 bounty from 1 project
TypeScript, JavaScript,
HTML & more
Cancel attempt
algora-pbc[bot] commented 1 day ago

💡 @krushnarout submitted a pull request that claims the bounty. You can visit your bounty board to reward.

krushnarout commented 1 day ago

@seveibar @imrishabh18 not sure but maybe an issue in production. works fine locally https://github.com/user-attachments/assets/fe38d4ef-5001-444c-84be-11304aea4baa

Correct! But the UX is bad after clicking on save button it still show unsaved changes for a while.

But I fixed it #328

https://github.com/user-attachments/assets/a8005c2d-1752-4613-aa45-58308fad1fa5

seveibar commented 1 day ago

It sounds like we need to validate that this works using the vercel preview url, if the issue still exists on production then the issue isnt resolved

seveibar commented 22 hours ago

/bounty $25

https://github.com/user-attachments/assets/9d414f26-d6cd-4bc8-9b95-ced97f6b4329

Please write a playwright test that goes through an entire typical edit flow and verifies in each state that "has unsaved changes"

RohittCodes commented 22 hours ago

/attempt #326

Algora profile Completed bounties Tech Active attempts Options
@RohittCodes 7 tscircuit bounties
TypeScript, JavaScript,
Python & more
﹟8
Cancel attempt
divanshu-go commented 17 hours ago

@seveibar I think we are not able to login on vercel preview url i have checked it see video for reference: https://github.com/user-attachments/assets/3c6cb27f-ee37-4220-b223-35eddb660752