search

tscircuit / snippets

https://snippets.tscircuit.com
MIT License
3 stars 15 forks source link

fixed:Search box doesn't render well in small views and dashboard responsiveness #85

Closed theajmalrazaq closed 1 week ago

theajmalrazaq commented 1 week ago

i have fixed issue #83 Search box doesn't render well in small views please add hacktobefest label image

vercel[bot] commented 1 week ago

@theajmalrazaq is attempting to deploy a commit to the tscircuit Team on Vercel.

A member of the Team first needs to authorize it.

seveibar commented 1 week ago

Can you show a screenshot with a mobile view

seveibar commented 1 week ago

Ah mobile view is different. This fix seems OK but i think we might want to improve the search bar there- its super small on md. I think maybe we could use a shadcn command modal when someone clicks the box on small screens?

theajmalrazaq commented 1 week ago

i think it seems perfect on mobile devices image

theajmalrazaq commented 1 week ago

@seveibar i also made dashboard responsive on mobile kindly review and merge Screenshot_select-area_20241018202347

Screenshot_select-area_20241018202317

seveibar commented 1 week ago

I would run "bun format" after editing, the first pr for a person on github i have to manually approve workflows

theajmalrazaq commented 1 week ago

Hi @seveibar, I sincerely apologize for the confusion caused. As a beginner, this is my first time contributing to a large open-source project, and I appreciate your understanding. Please kindly disregard any mistakes made.

seveibar commented 1 week ago

No worries! Just letting you know the first pr is always tricky and you might have to ping me more often 😁

theajmalrazaq commented 1 week ago

Haha, I think I’ve already pinged you more than 10 times! 😅 I really love your project and I’m excited to contribute more, especially with frontend bugs. You can definitely expect more pings from me!