tscircuit / snippets

https://snippets.tscircuit.com
MIT License
3 stars 15 forks source link

fixed:quickstart page responsiveness #95

Closed theajmalrazaq closed 5 days ago

theajmalrazaq commented 1 week ago

just fixed the quickstart page responsivess it is subpart of issue #25:mobile view is broken Screenshot_select-area_20241019124711 Screenshot_select-area_20241019124722

vercel[bot] commented 1 week ago

@theajmalrazaq is attempting to deploy a commit to the tscircuit Team on Vercel.

A member of the Team first needs to authorize it.

theajmalrazaq commented 1 week ago

@seveibar Done!!

seveibar commented 1 week ago

So it looks like youve changed the design on lg screens.

im mobile today so its harder to check work. Can you introduce a playwright snapshot test (see playwright-tests directory) for xs, md and lg sizes. This will also benefit the project because others will need to show their snapshot for future modifications

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **snippets** | ⬜️ Ignored ([Inspect](https://vercel.com/tscircuit/snippets/74wfuQHYZb2d1uwKQDGZEtzskpek)) | [Visit Preview](https://snippets-git-fork-theajmalrazaq-main-tscircuit.vercel.app) | Oct 19, 2024 6:36pm |
theajmalrazaq commented 1 week ago

@seveibar, this is how it looks on both devices. On large devices, there will be 3 columns, and on mobile, there will be 1 column. Furthermore, I am working on Playwright tests for 3 screen sizes: large, medium, and extra small, and I’m fixing the AI page UI. I will create their PR tomorrow. Also, I will work on setting the screen to ensure it is fixed across mobile. With all these updates, issue #25 will be closed. For now, please merge this.

Screenshot_select-area_20241020002600 Screenshot_select-area_20241020002546

theajmalrazaq commented 5 days ago

@seveibar doing it right away.

theajmalrazaq commented 5 days ago

@seveibar Done with this!