Update module and moduleResolution to stop using node and invalid combintations

tsconfig / bases

Hosts TSConfigs to extend in a TypeScript app, tuned to a particular runtime environment

MIT License

6.41k stars 240 forks source link

Update module and moduleResolution to stop using node and invalid combintations #197

Closed andrewbranch closed 1 year ago

andrewbranch commented 1 year ago

Per https://github.com/microsoft/TypeScript/pull/54567 and https://github.com/microsoft/TypeScript/issues/54735, I’m planning to make it an error to mix node16 module/moduleResolution with non-matching values for the other field. I’m also taking this opportunity to replace node (which is for Node 10!) with bundler where applicable.

orta commented 1 year ago

This all makes sense to me!

"moduleResolution": "bundler" might be a feature which came out on a later version of typescript, so I think we'll need to bump some versions (I think I need to start doing semver minors on these node builds) and that 👍🏻

andrewbranch commented 1 year ago

Yeah, it’s pretty new (5.0). I noticed some _version fields but I didn’t get how they were used. Do they just control the version of the published npm package?

orta commented 1 year ago

I'll do it, and I'll ping a few folks who should at least see this coming through:

@styfle (you might want this change in nextjs too)
@chriskrycho (this raises the lowest TS support to 5.0, is this something you are intentional about?) we can do a major server for your tsconfig version too
@dummdidumm (I don't think this should be too breaky for you?)
I don't think nuxt/remix are used in a more official capacity, so shouldn't worry too much there

I'll give it a few days before a merge, and I've sent you an invite to be a collab too

dummdidumm commented 1 year ago

Svelte change looks good to me 👍

orta commented 1 year ago

Cool, I think this is everything then 👍🏻

I've bumped the majors on all of the affected bases and noted why the esm build is deprecated

andrewbranch commented 1 year ago

Thanks all!

orta commented 1 year ago

For folks coming to this thread trying to figure to some of the types, I'd recommend looking at https://arethetypeswrong.github.io/

joeythomaschaske commented 1 year ago

Ran into a ton of problems with this change. Typescript recommends using node as the moduleResolution value

https://www.typescriptlang.org/docs/handbook/module-resolution.html#module-resolution-strategies

Note: node module resolution is the most-commonly used in the TypeScript community and is recommended for most projects. If you are having resolution problems with imports and exports in TypeScript, try setting moduleResolution: "node" to see if it fixes the issue.

andrewbranch commented 1 year ago

That page is many years out of date and will be deleted / completely rewritten soon.