search

tsconfig / bases

Hosts TSConfigs to extend in a TypeScript app, tuned to a particular runtime environment
MIT License
6.41k stars 240 forks source link

fix: set `allowJs` for `checkJs ` #218

Closed TatsuyaYamamoto closed 1 year ago

TatsuyaYamamoto commented 1 year ago

Currently bases/strictest.json has checkJs: true, but doesn't have allowJs: true and checkJs doesn't work.

https://github.com/microsoft/TypeScript/issues/21435#issuecomment-361757612

--checkJs really means nothing without --allowJs

orta commented 1 year ago

Yeah, I understand the tension here, but I think that including allowJs would be surprising for people.

Saying you want a stricter typescript environment shouldn't suddenly start expanding the scope of your project to include a bunch of files which are normally not included. I allowed checkJs because whenever you do choose to do that, by adding allowJs, you should have them checked

So thanks for the PR, but I'm afraid I'll politely decline