search

tsconfig / bases

Hosts TSConfigs to extend in a TypeScript app, tuned to a particular runtime environment
MIT License
6.41k stars 240 forks source link

Update @tsconfig/bun to reflect changes on bun docs #252

Closed risu729 closed 9 months ago

risu729 commented 9 months ago

This PR updates @tsconfig/bun to reflect changes on bun docs.

The changes are made recently to remove redundant options and fix inconsistency between docs and the generated tsconfig.json by the bun init command. https://github.com/oven-sh/bun/pull/8654, https://github.com/oven-sh/bun/pull/8953

The tsconfig is based on https://bun.sh/docs/typescript#suggested-compileroptions.

I'm not sure we should include the stricter flags (noUnusedLocals, noUnusedParameters, noPropertyAccessFromIndexSignature) which are disabled by default in bun init, because we can enable them by the combination of @tsconfig/bun and @tsconfig/strictest. ref: tsconfig-for-init.json

orta commented 9 months ago

I'm not sure we should include the stricter flags...

Generally I agree (for the same reasons) but I also prefer it being the same as the recommendations (even if I think those recommendations are overkill) - so this PR is fine as-is

risu729 commented 9 months ago

Sure. Thanks for merging!