search

tsconfig / bases

Hosts TSConfigs to extend in a TypeScript app, tuned to a particular runtime environment
MIT License
6.41k stars 240 forks source link

`strictest` should include `forceConsistentCasingInFileNames` (already included in `recommended`) #274

Closed sjohannes closed 2 months ago

sjohannes commented 2 months ago

forceConsistentCasingInFileNames was removed from strictest in https://github.com/tsconfig/bases/commit/ebe629c2857d386a0bc2c5d60cab18b9f1a425d0, but perhaps that was not intended? For reference, currently the option is included in recommended but not in strictest, which seems wrong.

Inconsistent filename casing is likely going to be due to a typo; it may work on Windows (e.g. on a developer's machine) but will fail on most Linux setups (e.g. on another developer's machine or on CI). I think it makes sense to have it enabled on both recommended and strictest.

zanminkian commented 2 months ago

The default value of forceConsistentCasingInFileNames is true since TS 5.0. Why do we still need it in strictest?

sjohannes commented 2 months ago

Oh I didn't realise, sorry; I thought the default was false.

Then (assuming we don't need to support TypeScript<5?) we should remove it from recommended as well. But I'll close this since it's not relevant anymore.

zanminkian commented 2 months ago

See readme below.

We target the latest stable version of TypeScript, note that because we want to be consistent with the versioning the target runtime we can't always do semver releases.

we should remove it from recommended as well.

No. See https://github.com/tsconfig/bases/issues/256#issuecomment-1970852034