search

tscrim / coxeter

Coxeter is a library for the study of combinatorial aspects of Coxeter group theory
11 stars 5 forks source link

Crash on specific matrix input #16

Open ghost opened 5 years ago

ghost commented 5 years ago

Hi!

Entering the following matrix

 1 0 2 3
 0 1 0 2
 2 0 1 0
 3 2 0 1

yields an Address Boundary Error. Running ddd on that seems to indicate that the error comes from 

(anonymous namespace)::InitMinTable::fillReflectionRow (this=0x7ffff7f46650, G=..., r=5, s=2 '\002') at minroots.cpp:837

I've looked at the code at this place but couldn't easily find the source of the bug. I'll try to look into it more carefully.

EDIT: (the matrix was input interactively)

EDIT2: After further investigation, it seems that at this line https://github.com/tscrim/coxeter/blob/7b5a1f0039511326aeb616afb132a5065886b9d8/minroots.cpp#L835 , the value for y is undef_minnbr, which I think shouldn't happen since we're then using it as an index.