search

tsdconseil / opencv-demonstrator

OpenCV demonstrator (GUI)
http://www.tsdconseil.fr/log/opencv/demo/index-en.html
GNU Lesser General Public License v3.0
141 stars 57 forks source link

Convert the rest of project to UTF-8 #14

Closed valera-rozuvan closed 8 years ago

valera-rozuvan commented 8 years ago

The XML files are in UTF-8 now (this was done as part of issue #5). We can proceed to to converting the rest of source files to UTF-8.

juliena82 commented 8 years ago

Technically, the rest of the project is already in UTF-8. In fact, it is (or should be) in ASCII (only English caracters).

valera-rozuvan commented 8 years ago

@juliena82 Not everything.

$ file -bi  ocvdemo/src/ocvdemo.cc 
text/x-c; charset=iso-8859-1
juliena82 commented 8 years ago

I said technically, meaning there are ASCII up to my knowledge. Your test show that there is (at least) an invalid chararacter in this file. Since you have the tools, can't you locate it and fix it?

valera-rozuvan commented 8 years ago

@juliena82 OK. I will do it. Some french characters are present in the source. For example:

// Image / vidéo par défaut

I will convert all of the files to UTF-8, and push this change to GitHub.

juliena82 commented 8 years ago

@valera-rozuvan Yes, but now that I think about it, there still may be some ISO8859 files in libcutil/data. Please don't touch touch them for now, I still use them for other projects, and in case, it breaks something, I want to do the things safely.

valera-rozuvan commented 8 years ago

@juliena82 OK. I will not touch the libcutil/data files.

juliena82 commented 8 years ago

Thanks

valera-rozuvan commented 8 years ago

@juliena82 In the libcutil/data folder, only the *.xml files should be converted to UTF-8? Right?

valera-rozuvan commented 8 years ago

@juliena82 To be more precise:

libcutil/data/model-editor-config-schema.xml
libcutil/data/std-lang.xml
libcutil/data/std-schema.xml
libcutil/data/view-schema.xml
valera-rozuvan commented 8 years ago

@juliena82 Before committing my changes, I will show you them to you. To be sure I don't screw up anything = )

valera-rozuvan commented 8 years ago

Fix for this issue is in Pull Request https://github.com/tsdconseil/opencv-demonstrator/pull/16.

juliena82 commented 8 years ago

I mean the files in libcutil/data should not be touched for now.

valera-rozuvan commented 8 years ago

@juliena82 OK. I will remove them from my Pull Request https://github.com/tsdconseil/opencv-demonstrator/pull/16/ .

valera-rozuvan commented 8 years ago

Fixed in PR https://github.com/tsdconseil/opencv-demonstrator/pull/16 .