Add test for compatibility with `@typescript-eslint/no-unsafe-call` rule - Githubissues

tsdjs / tsd

Check TypeScript type definitions

MIT License

2.4k stars 67 forks source link

Add test for compatibility with `@typescript-eslint/no-unsafe-call` rule #120

Closed BendingBender closed 3 years ago

BendingBender commented 3 years ago

Closes #99

sindresorhus commented 3 years ago

It passes because I worked around it in the lint config: https://github.com/xojs/eslint-config-xo-typescript/commit/5d67296b63c34ad9cc1f25b51a3bbde28e58afb6

When you remove linked workaround your test fails.

BendingBender commented 3 years ago

Yes, I know that you've made a workaround for this. I've reenabled this rule for this test (see https://github.com/SamVerschueren/tsd/pull/120/files#diff-c0316592149a0bea42c336d2b96889d6c72b0191d6ce058ed6df91073cf22f50R7) and I actually added a proof that it fails with a different construct for this rule (see https://github.com/SamVerschueren/tsd/pull/120/files#diff-7aba3dbc285f4db952e54a26767dd82ccf9db80fbc73636de365bf26f9de2b30R26) to be sure that the rule is actually enabled.

sindresorhus commented 3 years ago

Sorry, I missed that. Then I guess it was fixed somewhere.