fix(`expectError`): report missing diagnostic codes

tsdjs / tsd

Check TypeScript type definitions

MIT License

2.36k stars 68 forks source link

Closed tommy-mitchell closed 1 year ago

tommy-mitchell commented 1 year ago

expectError now behaves in three ways:

If an error is a syntactic error (diagnostic code less than 2000), don't display Expected an error message
If no error exists, log Expected an error, but found none.
Otherwise, log Found an error that tsd does not currently support (tsXXXX), consider creating an issue on GitHub.

tommy-mitchell commented 1 year ago

Should probably also document in the readme that syntax errors can’t be ignored.

sindresorhus commented 1 year ago

Thanks :)