search

tsdjs / tsd

Check TypeScript type definitions
MIT License
2.36k stars 68 forks source link

Replace Ava by Vitest #180

Open skarab42 opened 1 year ago

skarab42 commented 1 year ago

Motivation: #175

tsd-vitest

tommy-mitchell commented 1 year ago

Would this allow to build in watch mode, too?

skarab42 commented 1 year ago

Would this allow to build in watch mode, too?

Yes, but it need a small modification for the chmod, I'll do that tomorrow.

sindresorhus commented 1 year ago

I think this should have been discussed in an issue first.

sindresorhus commented 1 year ago

Using ts-node could probably have achieved the same thing in a few lines of code without rewriting everything.

sindresorhus commented 1 year ago

My concern with switching test runner is that most test runners do too much, which means a lot of bugs. I personally saw this when Jest became popular. It solved a lot of real use-cases true, but it also caused a lot of annoyance by being super buggy. I generally prefer simplicity. However, this is not my repo, so I'm not the one you have to convince.

skarab42 commented 1 year ago

I think this should have been discussed in an issue first.

It's not a big deal, I had fun doing it, do what you want with it ;)