search

tsechingho / chosen-rails

Integrate Chosen javascript library with Rails asset pipeline
https://github.com/tsechingho/chosen-rails
MIT License
524 stars 233 forks source link

Remove compass-rails dependency #79

Closed mauro-ni closed 8 years ago

mauro-ni commented 9 years ago

Hi guys, chosen-rails is a great gem, but depends on compass-rails one. The compass-rails gem locks sprockets to version 2.12.4 and unfortunately its maintenance is sporadic. Is it possible to remove this dependency? Is it possible to automatically generate a scss file that does not require compass and put it in the gem?

Many thanks, Mauro

vad4msiu commented 9 years ago

:+1: for removal compass-rails

asecondwill commented 9 years ago

+1

mlensment commented 9 years ago

+1

brendon commented 8 years ago

Yes please! :)

asiniy commented 8 years ago

+1

tirdadc commented 8 years ago

+1, this is the only thing preventing an upgrade to Sprockets 3 for me.

tsechingho commented 8 years ago

Hi, all. I will remove compass-rails dependency IN THESE DAYS.

mauro-ni commented 8 years ago

@tsechingho thank you! I'm using the gem in a dozen of apps and it is the only thing preventing an upgrade to Sprockets 3.

rhatherall commented 8 years ago

+1

chungphuoc commented 8 years ago

+1

thucnguyen commented 8 years ago

+1

marciotoze commented 8 years ago

+1

maltesa commented 8 years ago

+1

mauro-ni commented 8 years ago

Hope to see a new release soon :)

mauro-ni commented 8 years ago

A new version of compass-rails has been released: sprockets no longer locked to version 2.

knightq commented 8 years ago

+1

knightq commented 8 years ago

Any hope to see this promised release soon?

zedtux commented 8 years ago

+1

tsechingho commented 8 years ago

I finally have time to do this.

compass-rails is no longer a dependency from chosen-rails 1.5.1, please see readme.

brendon commented 8 years ago

Thanks for this! :)

mauro-ni commented 8 years ago

@tsechingho thank you, but it is not working unless you put compass-rails in Gemfile (as specified in README). If I don't put compass-rails in Gemfile I get the following error:

cannot load such file -- compass-rails (LoadError)
  /usr/local/rvm/gems/ruby-2.3.0/gems/chosen-rails-1.5.1/lib/chosen-rails.rb:17:in 'require'
  /usr/local/rvm/gems/ruby-2.3.0/gems/chosen-rails-1.5.1/lib/chosen-rails.rb:17:in '<top (required)>'
  /usr/local/rvm/gems/ruby-2.3.0/gems/bundler-1.11.2/lib/bundler/runtime.rb:77:in 'require'
  /usr/local/rvm/gems/ruby-2.3.0/gems/bundler-1.11.2/lib/bundler/runtime.rb:77:in 'block (2 levels) in require'
  /usr/local/rvm/gems/ruby-2.3.0/gems/bundler-1.11.2/lib/bundler/runtime.rb:72:in 'each'
  /usr/local/rvm/gems/ruby-2.3.0/gems/bundler-1.11.2/lib/bundler/runtime.rb:72:in 'block in require'
  /usr/local/rvm/gems/ruby-2.3.0/gems/bundler-1.11.2/lib/bundler/runtime.rb:61:in 'each'
  /usr/local/rvm/gems/ruby-2.3.0/gems/bundler-1.11.2/lib/bundler/runtime.rb:61:in 'require'
  /usr/local/rvm/gems/ruby-2.3.0/gems/bundler-1.11.2/lib/bundler.rb:99:in 'require'
  ...
tsechingho commented 8 years ago

@maurosbu you are right, I forgot to remove the require line in /lib. You have v1.5.2 now.

mauro-ni commented 8 years ago

@tsechingho thank you, it is working now!!!

zedtux commented 8 years ago

Thank you @tsechingho !

justinxreese commented 8 years ago

I feel like the references to compass should be removed from the README. Is there any reason to keep them now? They seem to just add confusion now that it is no longer a dependency.

brendon commented 8 years ago

@justinxreese, since this issue is closed, you should open a new issue so that it gets more visibility. Or since it's a quick change, do a pull request with the compass parts removed from the README and @tsechingho can go from there :)

justinxreese commented 8 years ago

I figured it was worth a slight mention here because I didn't know if there was a good reason it was still in that could easily be dismissed. But I think a new issue might be worth adding now.

On Mon, Aug 29, 2016 at 5:43 PM Brendon Muir notifications@github.com wrote:

@justinxreese https://github.com/justinxreese, since this issue is closed, you should open a new issue so that it gets more visibility. Or since it's a quick change, do a pull request with the compass parts removed from the README and @tsechingho https://github.com/tsechingho can go from there :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tsechingho/chosen-rails/issues/79#issuecomment-243266433, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJNNzBy1wcmTc6Z5hixm7fptMCusPumks5qk1JkgaJpZM4GNy3Z .