search

tsechingho / ckeditor-rails

Integrate CKEditor javascript library with Rails asset pipeline
https://github.com/tsechingho/ckeditor-rails
MIT License
214 stars 133 forks source link

Custom config.js getting overwritten by gem updates #99

Open alextyrsmith opened 1 year ago

alextyrsmith commented 1 year ago

Hello and thank you for the gem!

I ran across an issue recently on a Heroku app using this gem. The app is using a custom config.js (CKEDITOR.editorConfig = function () { our custom config, etc, etc }defined in ckeditor/config.js). What appears to be happening was the version of this gem got bumped inadvertently from 4.16.3 to 4.17.0.

Now the javascript files, including the default provided config.js and the custom overwritten config.js file, all get fingerprinted in the Rails asset pipeline. The rake task portion provided by this gem then sorts the files of the pipeline output by time updated (mtime) and maps the latest fingerprinted one back to the non-digest /config.js file. Because the latest updated fingerprinted file is the default file now, the custom config in our app gets overwritten and the CKeditor instance doesn't get the config we want.

Is there a way to ignore the default config file during the asset pipeline run?

odarriba commented 1 year ago

I experienced the same issue and fixed it by locking the gem to the 4.16.2 version, but it would be awesome if it can be fixed in order to be able to update the gem as expected.