search

tsedio / tsed-formio

Repository dedicated to formiojs.
https://formio.tsed.io
14 stars 8 forks source link

tech(test): give more context to data-testid #46

Closed Mitchnsun closed 2 years ago

Mitchnsun commented 2 years ago

This is a suggestion for using data-testid in some HTML element as inputs I give more context in the data-testid to be easier to target it. For example: when multiple inputs are displayed, they all have data-testid="input". It is not helping to target it when testing. To target a specific input a data-testid with context is easier data-testid="input_name". For targeting all inputs with react testing library, it is better to target by role.

Romakita commented 2 years ago

:tada: This PR is included in version 1.10.11 :tada:

The release is available on:

Your semantic-release bot :package::rocket: