tseemann / prokka

:zap: :aquarius: Rapid prokaryotic genome annotation
822 stars 224 forks source link

Parallel version detection #561

Open ole-tange opened 3 years ago

ole-tange commented 3 years ago

Hi

This:

  'parallel' => {
    GETVER  => "parallel --version | grep -E 'parallel 2[0-9]{7}\$'",
    REGEXP  => qr/parallel (\d+)/,
    MINVER  => "20130422",
    NEEDED  => 1,
  },

is not supported by GNU Parallel (in other words it may break in future versions). However, this is:

parallel --minversion 20130422 || echo Version 20130422 needed

It will both set the exit code and output the version number (which is probably what you are going to use).

--minversion is specifially built for situations like this.

So this will probably work:

  'parallel' => {
    GETVER  => "parallel --minversion 20130422",
    REGEXP  => qr/(\d+)/,
    MINVER  => "20130422",
    NEEDED  => 1,
  },
andersgs commented 3 years ago

Thank you @ole-tange! And thank you for developing parallel!!