tseemann / snp-dists

Pairwise SNP distance matrix from a FASTA sequence alignment
GNU General Public License v3.0
127 stars 28 forks source link

Lower tri #34

Closed schultzm closed 5 years ago

schultzm commented 5 years ago

Hi @tseemann

This pull request aims to provide the feature request in issue #33.

The main changes are:

I have tested it on real data and it worked for me as expected, with the output file parseable by quicktree. I haven't added a test to .travis.yaml as I wasn't sure how you were going to implement the tests.

Cheers,

kloetzl commented 5 years ago

Hi Mark,

I left a few comments on your code. Personally, I would be happy to see a phylip-style matrix. However, I would prefer a full matrix. Some tools expect that; and converting a full matrix to a lower-only is much easier than the other way round. (Parsing the lower-only phylip format is surprisingly hard.)

Thanks for your contribution, Fabian