search

tsenart / vegeta

HTTP load testing tool and library. It's over 9000!
http://godoc.org/github.com/tsenart/vegeta/lib
MIT License
23.51k stars 1.36k forks source link

Refactor target parser #141

Closed tsenart closed 6 years ago

tsenart commented 9 years ago

The current parser code isn't very modular and could be simplified.

ei-grad commented 7 years ago

@tsenart hi! Thanks for a great tool.

I want to deal with target parser refactoring to be able to use it in my own load testing tool. If there are nobody working on this currently, then you could expect a pull-request from me in a month or so (so long because my own load testing project is not the main thing I work on).

Would it be ok if I move target parsing to github.com/tsenart/vegeta/target package?

Any other suggestions / requirements / whishes?

tsenart commented 7 years ago

Hello @ei-grad! Thanks for proposing to work on this. I suggest you approach this with small incremental steps and put all of this up for me to review regularly.

Let's start with everything in the same package as it currently is. Also please bring forward a bit more specifics of how you plan to refactor this.

tsenart commented 6 years ago

Closed in favor of https://github.com/tsenart/vegeta/pull/300