Closed topliceanu closed 7 years ago
I'd just allow any string as method instead of defining the allowed ones per attack.
My thinking was that the targets file could come from a source you don't control, so you might need some method of checking. However you are absolutely right, allowing any word to be a verb is a MUCH simpler solution. I will open a PR for that.
rationale
context
echo "SUBSCRIBE http://localhost" | vegeta attack -http2 | tee /tmp/results.vegeta | vegeta report
and I got back2017/01/19 21:58:42 bad method: SUBSCRIBE
and an empty report.implementation
vegeta attack
gets a new options-allowed-methos=APPEND,SUBSCRIBE
which is a list of comma-separated verbs allowed in targets. This list of allowed methods gets passed to the Targetervegeta attack
allows any ASCII upper-case word to be used as HTTP verb.a WIP PR is here https://github.com/tsenart/vegeta/pull/213The new PR is here https://github.com/tsenart/vegeta/pull/217