tsenart / vegeta

HTTP load testing tool and library. It's over 9000!
http://godoc.org/github.com/tsenart/vegeta/lib
MIT License
23.51k stars 1.36k forks source link

Vegeta should support body file input via URL #272

Closed pswenson closed 6 years ago

pswenson commented 6 years ago

I think it would be useful for vegeta to support -body from a URL. If running in a docker container or on multiple remote servers, it can be a hassle to move files to the correct location. Having option to host file via URL make usage easier

daluu commented 6 years ago

Good suggestion. For docker though, couldn't you just store files in a central file store accessible by docker (host) infrastructure, and map that filestore path (on docker host) to a local path on the docker container? And that is same static path mapping for all vegeta docker containers that are started.

pswenson commented 6 years ago

sure, it's possible to map volumes to share files and launch docker. But it would be must more usable to be able to ssh to a server and simply run a docker command to start a load test (no scp-ing files)

tsenart commented 6 years ago

If you have curl in your Docker image, then this is trivial. What prevents you from using curl before the attack to download your body file?

pswenson commented 6 years ago

nothing prevents using curl.. it's a purely a convenience + a commonly used pattern

e.g. if you are a kuberenetes user here are some sample commands: $ kubectl create -f myresource.yaml # create resource(s) from yaml file $ kubectl create -f https://git.io/vPieo # create resource(s) from url

On Fri, May 18, 2018 at 4:45 AM Tomás Senart notifications@github.com wrote:

If you have curl in your Docker image, then this is trivial. What prevents you from using curl before the attack to download your body file?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tsenart/vegeta/issues/272#issuecomment-390169591, or mute the thread https://github.com/notifications/unsubscribe-auth/AAaRInMX9w1hcthwUsCAj4i3Dwndimosks5tzqY7gaJpZM4Q7dH5 .

tsenart commented 6 years ago

While I understand where this request is coming from, it is quite at odds with the UNIX philosophy that Vegeta is built with and that I'm striving to maintain. In any case, thank you for the proposal!