Closed fenollp closed 5 years ago
As a temporary workaround I tagged my own fork.
I think this sounds reasonable. I'll update the README to explain this and push the appropriate tags going forward.
Amazing! Looking forward to the next tag :)
Done!
Hi there,
Trying to setup a project on go1.11 using
go mod
and the vegeta lib. So basically I set up a new project outside$GOPATH
with the example code from the README.md then rango mod init github.com/fenollp/bla
thengo build
complains thatvegeta.Rate
doesn't exist.The issue is that go modules are very restrictive in the naming of the tags they can use. They want tags of the form
vX.Y.Z
where X,Y,Z are digits.The things is you're prepending
cli/
andlib/
to your tags and while that makes sense it makes it impossible to use go modules as well as a version of vegeta that's more recent thanv8.0.0
(as this was the last tag thatgo mod is happy with
).So what do you think about tagging lib releases with
vX.Y.Z
as well aslib/vX.Y.Z
(and keep tagging CLI the same way as a go project is unlikely to depend on the CLI version throughgo mod
)?Thanks