tsenart / vegeta

HTTP load testing tool and library. It's over 9000!
http://godoc.org/github.com/tsenart/vegeta/lib
MIT License
23.51k stars 1.36k forks source link

Two different .bin file plotting color wonder #498

Closed ARuei closed 1 year ago

ARuei commented 4 years ago

Question

Hi guys,

I just used vegeta tool to create two different bin files, and plot them by $vegeta plot result1.bin result2.bin > plot.html

The colors generated by plot look similar which make it hard to tell. Is there any change I could make to adjust the line color distribution? The illustrated figure looks like distinct and easy to tell by simply looking at the color.

Also, the number in bottom left corner means moving average window size (in data point), I do not understand why we just simply modify the values and the latency will change respectively.

Sorry if I asked the dumb questions...

mciastek commented 3 years ago

It looks like line colors are hardcoded in the script. See:

https://github.com/tsenart/vegeta/blob/19b74586217105bbde8ded6077c70095e97146bf/lib/plot/plot.go#L264-L281 https://github.com/tsenart/vegeta/blob/19b74586217105bbde8ded6077c70095e97146bf/lib/plot/plot.go#L253-L261

Maybe it could be a parameter passed to plot command? @tsenart what do you think?

tsenart commented 1 year ago

This has been fixed in 60c2d660882aa630a4dd08a110955de94beb4cb6