search

tsenart / vegeta

HTTP load testing tool and library. It's over 9000!
http://godoc.org/github.com/tsenart/vegeta/lib
MIT License
23.51k stars 1.36k forks source link

Does vegeta prevent coordinated omission? #520

Closed toaler closed 1 year ago

toaler commented 4 years ago

Question

Similar to this question [1] does vegeta prevent coordination omission. I haven't been able to find a load generator that supports h2 and prevents coordinated omission.

[1] https://github.com/artilleryio/artillery/issues/721#issue-469383966

tsenart commented 4 years ago

Yes, it does. By default it will keep sending requests at specified rate, regardless of how slow the server is to respond.

Sent via Superhuman iOS ( https://sprh.mn/?vip=tsenart@gmail.com )

On Thu, Jun 11 2020 at 1:46 AM, Brian Toal < notifications@github.com > wrote:

Question

Similar to this question [1] does vegeta prevent coordination omission. I haven't been able to find a load generator that supports h2 and prevents coordinated omission.

[1] artilleryio/artillery#721 (comment) ( https://github.com/artilleryio/artillery/issues/721#issue-469383966 )

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ( https://github.com/tsenart/vegeta/issues/520 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAAQPD5XUCVYYMKVK6SQLRTRWALNPANCNFSM4N24UIDA ).

toaler commented 4 years ago

Thanks for the quick response @tsenart. Does it make sense to include that as a feature on the Readme.md? This is a great differentiator of this workload generator compared to others.

Michael-Frank commented 4 years ago

second that! A statement about coordintated ommision should be on top of the readme, preferable line 2 in <h1> It is THE most important feature in the sea of load generators. Tool and its features do not matter, if the produced numbers are garbage. There should be a "A+ Coordinated Ommission aware" banner or something like that 😀 Edit: just discovered your @tsenart where in close contact with giltene himself! https://github.com/tsenart/vegeta/pull/92 Cudos! A reason more to mention this as a killer feature in the readme 👍

nukemberg commented 3 years ago

Well, not exactly. Vegeta properly handles it if the request is TCP accepted but if it is waiting on the TCP socket backlog queue it will be backpressured and act as a closed system with coordinated omission. Don't know how common this is for most ppl but worth mentioning in case someone runs into it.

tsenart commented 1 year ago

Added to the README: https://github.com/tsenart/vegeta/commit/53fd7bace2f7aeea5c9c17be94bbcb3cfb162190